Review Request 118804: Register ksmserver as logind session leader

Elias Probst mail at eliasprobst.eu
Thu Jun 19 12:15:45 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118804/
-----------------------------------------------------------

(Updated June 19, 2014, 12:15 p.m.)


Review request for Plasma.


Changes
-------

Use the Session, not the Manager interface.


Bugs: 335390
    https://bugs.kde.org/show_bug.cgi?id=335390


Repository: plasma-workspace


Description
-------

This is an initial (not yet working) attempt to fix bug#335390.

Currently, the attempt for TakeControl() is rejected by org.freedesktop.login1:

Failed to register as session leader:  "Rejected send message, 2 matched rules; type="method_call", sender=":1.345" (uid=1000 pid=23689 comm="/usr/bin/ksmserver ") interface="org.freedesktop.login1.Manager" member="TakeControl" error name="(unset)" requested_reply="0" destination="org.freedesktop.login1" (uid=0 pid=2553 comm="/usr/lib/systemd/systemd-logind ")"


Diffs (updated)
-----

  ksmserver/screenlocker/logind.cpp dcfc7f321b3cf29ef68aac8006aa37f5e4e00956 

Diff: https://git.reviewboard.kde.org/r/118804/diff/


Testing
-------

- Copy /usr/lib/systemd/system/systemd-logind.service to /etc/systemd/system/systemd-logind.service
- Set "Environment=SYSTEMD_LOG_LEVEL=debug" in the [Service] section of /etc/systemd/system/systemd-logind.service
- Run "systemctl daemon-reload"
- Reboot (also possible without a reboot, but far more complicated and requires to terminate the X session anyways, so a reboot is the most straightforward solution)

To test
- apply patch + rebuild plasma-workspace
- kill ksmserver
- Run "journalctl -n 20 -f -u systemd-logind" to monitor logind
- Run "tail -f ~/.xsession-errors" or "journalctl --user -n 20 -f --user-unit ksmserver" (for systemd user-session users) to monitor ksmserver's output
- restart ksmserver


Thanks,

Elias Probst

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140619/d3e9317d/attachment.html>


More information about the Plasma-devel mailing list