Review Request 118799: Move BatteryIcon to org.kde.plasma.extras

Marco Martin notmart at gmail.com
Wed Jun 18 15:33:23 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118799/#review60422
-----------------------------------------------------------


would have preferred something private just for the battery, org.kde.plasma.workspace.components makes too easy to make it a dumpster...

aaanyways, that's fine iff adding or modifying anything in org.kde.plasma.workspace.components will be something done with extreme care, and only when every other solution is exausted

- Marco Martin


On June 17, 2014, 10:47 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118799/
> -----------------------------------------------------------
> 
> (Updated June 17, 2014, 10:47 p.m.)
> 
> 
> Review request for Plasma and Solid.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> This way we can share it between the Breeze lookandfeel and the Battery plasmoid. At the moment it's forked.
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/plasmaextracomponents/qml/BatteryIcon.qml PRE-CREATION 
>   src/declarativeimports/plasmaextracomponents/qml/qmldir c59e62f 
> 
> Diff: https://git.reviewboard.kde.org/r/118799/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140618/bd92614c/attachment.html>


More information about the Plasma-devel mailing list