Review Request 118716: New Translations KCM
Sebastian Kügler
sebas at kde.org
Wed Jun 18 14:28:43 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118716/
-----------------------------------------------------------
(Updated June 18, 2014, 2:28 p.m.)
Status
------
This change has been marked as submitted.
Review request for Plasma, Chusslove Illich and John Layt.
Repository: plasma-desktop
Description
-------
This is the second part of the replacement of the Locale KCM: Translations.
This KCM complements the formats KCM, which sets the locale. With this KCM, the user can configure GUI translations.
The mechanism to set up the langhere, KF5-uage is the same as in the formats KCM, while formats set LC_* and LANG, this KCM will set LANGUAGE. The UI is roughly the same as in the previous "Locale", though here, KF5-compatible mechanism (QLocale, ki18n, are used.
This code has been written by John Layt, I've merely cleaned it up a bit, added some missing features, tested it and am submitting it now for review.
Diffs
-----
kcms/CMakeLists.txt 76887e2
kcms/formats/kcmformats.h 345fbb1
kcms/formats/kcmformats.cpp 78cfb98
kcms/formats/writeexports.h PRE-CREATION
kcms/translations/CMakeLists.txt PRE-CREATION
kcms/translations/Messages.sh PRE-CREATION
kcms/translations/kcmtranslations.h PRE-CREATION
kcms/translations/kcmtranslations.cpp PRE-CREATION
kcms/translations/kcmtranslationswidget.ui PRE-CREATION
kcms/translations/translations.desktop PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/118716/diff/
Testing
-------
Set up languages (x-test, others), re-logged in, languages correctly set up for KF5 and console applications.
File Attachments
----------------
KCM in systemsettings
https://git.reviewboard.kde.org/media/uploaded/files/2014/06/13/28a00558-f671-4f39-bfe3-ca9dca8e98ce__tranlationskcm.png
Thanks,
Sebastian Kügler
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140618/9c2f4538/attachment.html>
More information about the Plasma-devel
mailing list