Review Request 118662: fix plugin install target for phonon platform plugin

Aurélien Gâteau agateau at kde.org
Wed Jun 18 14:23:59 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118662/#review60415
-----------------------------------------------------------

Ship it!


I confirm the plugin installs and loads correctly now.

- Aurélien Gâteau


On June 11, 2014, 10:51 a.m., Harald Sitter wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118662/
> -----------------------------------------------------------
> 
> (Updated June 11, 2014, 10:51 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> ${PLUGIN_INSTALL_DIR} already contains /plugins so appending it manually leads to /plugins/plugins/ as dir
> 
> dpkg -L project-neon5-plasma-workspace |grep phonon
> /opt/project-neon5/lib/x86_64-linux-gnu/plugins/plugins/phonon_platform
> /opt/project-neon5/lib/x86_64-linux-gnu/plugins/plugins/phonon_platform/kde.so
> /opt/project-neon5/share/knotifications5/phonon.notifyrc
> /opt/project-neon5/share/kservicetypes5/phononbackend.desktop
> 
> 
> Diffs
> -----
> 
>   phonon/platform_kde/CMakeLists.txt a42c213ad212631079cf0d03a7f8cb9f4b1278d1 
> 
> Diff: https://git.reviewboard.kde.org/r/118662/diff/
> 
> 
> Testing
> -------
> 
> builds and installs without having /plugins/ twice in the target path
> 
> 
> Thanks,
> 
> Harald Sitter
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140618/6b9ab3a2/attachment.html>


More information about the Plasma-devel mailing list