Review Request 118813: [declarativeimports/core] Do not crash if FadingMaterialShader failed to complie
Martin Gräßlin
mgraesslin at kde.org
Wed Jun 18 13:18:48 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118813/
-----------------------------------------------------------
(Updated June 18, 2014, 1:18 p.m.)
Status
------
This change has been marked as submitted.
Review request for Plasma.
Bugs: 336272
http://bugs.kde.org/show_bug.cgi?id=336272
Repository: plasma-framework
Description
-------
[declarativeimports/core] Do not crash if FadingMaterialShader failed to complie
Without GLSL our shader doesn't compile and Qt aborts when accessing the
uniforms. We don't want that, abort is never nice.
BUG: 336272
Diffs
-----
src/declarativeimports/core/fadingnode.cpp 0c41ec1f4cc2fe78af59dfb1c705bbc65697380b
Diff: https://git.reviewboard.kde.org/r/118813/diff/
Testing
-------
Thanks,
Martin Gräßlin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140618/780b4a7f/attachment.html>
More information about the Plasma-devel
mailing list