Review Request 118812: [plasmashell] Show a warning if there are no Shaders and exit

[Martin Gräßlin]

> On June 18, 2014, 3 p.m., David Edmundson wrote:
> > So this patch uses hasOpenGLShaderPrograms which doesn't work and QCoreApplication::exit() which doesn't work? 
> > That's both the major points of this patch, no?

well, the hasOpenGLShaderProgram is addressed in https://codereview.qt-project.org/87736

The QCoreApplication::exit() is something I do not understand and I just hoped someone has an idea when I post it for review.


> On June 18, 2014, 3 p.m., David Edmundson wrote:
> > shell/shellcorona.h, line 87
> > <https://git.reviewboard.kde.org/r/118812/diff/1/?file=282338#file282338line87>
> >
> >     private?

are private slots invokable through QMetaObject::invokeMethod?


> On June 18, 2014, 3 p.m., David Edmundson wrote:
> > shell/shellcorona.cpp, line 1232
> > <https://git.reviewboard.kde.org/r/118812/diff/1/?file=282339#file282339line1232>
> >
> >     just QCoreApplication::exit()

I think it makes sense to have the error code. This could allow startkde to abort the startup.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118812/#review60395
-----------------------------------------------------------


On June 18, 2014, 1:36 p.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118812/
> -----------------------------------------------------------
> 
> (Updated June 18, 2014, 1:36 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> [plasmashell] Show a warning if there are no Shaders and exit
> 
> If there are no Shaders Plasma doesn't work. If we detect this we show
> a warning (without GL) and exit.
> 
> This doesn't really work as Qt has a bug which doesn't allow to detect
> whether Shaders are supported and the exit just doesn't work.
> 
> 
> Diffs
> -----
> 
>   shell/shellcorona.h f500e837b5957e14e70ac4b24da0cdf7970a7171 
>   shell/shellcorona.cpp 4abe3432f30a8c4eb90806893f15c7c50f0e1ac2 
> 
> Diff: https://git.reviewboard.kde.org/r/118812/diff/
> 
> 
> Testing
> -------
> 
> With Mesa drivers:
> LIBGL_ALWAYS_INDIRECT=1 plasmashell
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140618/dc19aee3/attachment-0001.html>