Review Request 118799: Move BatteryIcon to org.kde.plasma.extras

[Aleix Pol Gonzalez]

> On June 17, 2014, 4:21 p.m., Marco Martin wrote:
> > I'm not a fan of throwing random pieces in public api just because they are useful in 2 places,
> > especially since the other place where that may be useful is the lock screen, and that had the possibility of adding directly plasmoids planned

I think it's an overkill to use the plasmoid there, because we will still have to add the % text anyway.


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118799/#review60284
-----------------------------------------------------------


On June 17, 2014, 4:02 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118799/
> -----------------------------------------------------------
> 
> (Updated June 17, 2014, 4:02 p.m.)
> 
> 
> Review request for Plasma and Solid.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> This way we can share it between the Breeze lookandfeel and the Battery plasmoid. At the moment it's forked.
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/plasmaextracomponents/qml/BatteryIcon.qml PRE-CREATION 
>   src/declarativeimports/plasmaextracomponents/qml/qmldir c59e62f 
> 
> Diff: https://git.reviewboard.kde.org/r/118799/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140617/df318023/attachment.html>