Review Request 118796: [notifications] Introduce a list of apps that are limited to single notification only

[Sebastian Kügler]

> On June 17, 2014, 2:55 p.m., Martin Gräßlin wrote:
> > dataengines/notifications/notificationsengine.cpp, lines 38-48
> > <https://git.reviewboard.kde.org/r/118796/diff/1/?file=281959#file281959line38>
> >
> >     suggestion - C++11-ify:
> >     , m_alwaysReplaceAppsList({QStringLiteral("Clementine"), QStringLiteral("Spotify")})
> >     
> >     That way you safe two appends to the list and could even make the list const.

Would it make sense to make it possible to override this from a config file? 

I can imagine once we hit a larger userbase, that more of these "rogue" apps that spam the notification queue turn up, and then it'd be nice to ask users if adding a config entry for those helps (so we can perhaps include it in the defaults with the next release).


- Sebastian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118796/#review60261
-----------------------------------------------------------


On June 17, 2014, 2:36 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118796/
> -----------------------------------------------------------
> 
> (Updated June 17, 2014, 2:36 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> This prevents some apps to spam lots of notifications when all it needs is actually just one single notification.
> 
> Imagine you're switching songs in your playlist quickly and each song change sends new notification, but when
> you get to the tenth song, you still see the notification from the 3rd song (because timeouts) and you don't
> really care about all those songs changes still in the queue as you see it in the playlist anyway. 
> 
> So this patch limits certain apps to have only one single notification which is always updated. So far
> Clementine and Spotify is there. Switching songs or changing playback status creates only one single popup.
> 
> 
> Diffs
> -----
> 
>   applets/notifications/package/contents/ui/NotificationPopup.qml d07ee32 
>   applets/notifications/plugin/notificationshelper.cpp 9c6c716 
>   dataengines/notifications/notificationsengine.h df0d3ca 
>   dataengines/notifications/notificationsengine.cpp aaf6079 
> 
> Diff: https://git.reviewboard.kde.org/r/118796/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140617/38241296/attachment-0001.html>