Review Request 118793: Remove old display KCM

Commit Hook null at kde.org
Tue Jun 17 13:11:42 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118793/#review60244
-----------------------------------------------------------


This review has been submitted with commit 7edf073609bf420c250348e63cdb2584136c2e14 by Elias Probst to branch master.

- Commit Hook


On June 17, 2014, 12:55 p.m., Elias Probst wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118793/
> -----------------------------------------------------------
> 
> (Updated June 17, 2014, 12:55 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> Drop old display KCM in favor of kscreen's KCM.
> 
> The old display KCM
> - doesn't seem to work anymore (shows only a gray empty window)
> - is not included in 'System Settings' anymore
> - still shows up in search results (krunner, milou, ...)
> - is superseded by kscreen
> 
> 
> Diffs
> -----
> 
>   kcms/hardware/CMakeLists.txt ab222935903f2c10562e4a74f7933bf694d6e818 
>   kcms/hardware/display/CMakeLists.txt ab8225f13ecf1623a6de28d20b467ecd306a368b 
>   kcms/hardware/display/Messages.sh 561ccd0d8b2167dda6c354cff924166806c176ce 
>   kcms/hardware/display/display.cpp a0392821f80081bb1c6dc2e38af0a7acd41dcfd8 
>   kcms/hardware/display/display.desktop e8eff615aee5a27651ae56da909f3ecc2db09781 
>   kcms/hardware/display/display.h 7e0c342240eb3559c555c2ea6635987fa18f7ba6 
> 
> Diff: https://git.reviewboard.kde.org/r/118793/diff/
> 
> 
> Testing
> -------
> 
> Building plasma-desktop with this patch doesn't install these files anymore:
> /usr/share/kservices5/display.desktop
> /usr/lib64/plugins/kcm_display.so
> 
> 
> Thanks,
> 
> Elias Probst
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140617/89d80358/attachment-0001.html>


More information about the Plasma-devel mailing list