Review Request 118791: (Need opinions) KRunner: Avoid having a scroll area
Vishesh Handa
me at vhanda.in
Tue Jun 17 11:07:29 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118791/
-----------------------------------------------------------
Review request for Plasma.
Repository: plasma-workspace
Description
-------
This is an experiment.
I've removed the scroll area in the KRunner, and now all of the results are shown. I'm not totally convinced if this is a good idea, hence the review request.
Advantages -
* You can see all of the results
Disadvantages -
* Consumes more space
* Less consistent with the old runner as now it no longer has a scroll area
Currently the way the code is structured, the model only shows 20 results. We need to tell the model a maximum number as it decides how many results should be shown per category based on that number.
Diffs
-----
lookandfeel/contents/runcommand/RunCommand.qml 7a0503d
Diff: https://git.reviewboard.kde.org/r/118791/diff/
Testing
-------
File Attachments
----------------
Krunner in its full view
https://git.reviewboard.kde.org/media/uploaded/files/2014/06/17/a5743542-405a-4346-aa26-ac9158215555__krunner.png
Thanks,
Vishesh Handa
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140617/d7afc9bc/attachment.html>
More information about the Plasma-devel
mailing list