Review Request 118678: [ki18n] Allow querying for translations of a specific domain

Commit Hook null at kde.org
Mon Jun 16 21:32:25 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118678/#review60213
-----------------------------------------------------------


This review has been submitted with commit d09bfbd3949688c3eaf422cd785f77c96ff6e399 by Sebastian Kügler to branch master.

- Commit Hook


On June 16, 2014, 2:43 p.m., Sebastian Kügler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118678/
> -----------------------------------------------------------
> 
> (Updated June 16, 2014, 2:43 p.m.)
> 
> 
> Review request for Plasma, Chusslove Illich and John Layt.
> 
> 
> Repository: ki18n
> 
> 
> Description
> -------
> 
> Allow querying for translations of a specific domain
> 
> In the new translations KCM, we want to list available languages for the
> workspace. This might, or might not be the same application domain as
> the one set (current translation is different from installed
> translations). In order to list the installed translations, we need to
> specify that domain, independently from the one set in
> KLocalizedString's global static.
> 
> With this patch, I can successfully list installed languages in the new KCM.
> 
> 
> I'm not super-familiar with how this stuff works, there might be a better way, 
> in which case I'm sure you guys will enlighten me. :)
> 
> 
> Diffs
> -----
> 
>   src/klocalizedstring.h 1a9fce8 
>   src/klocalizedstring.cpp e12d6df 
> 
> Diff: https://git.reviewboard.kde.org/r/118678/diff/
> 
> 
> Testing
> -------
> 
> Tested new translations KCM, languages show up.
> 
> 
> Thanks,
> 
> Sebastian Kügler
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140616/15b53639/attachment-0001.html>


More information about the Plasma-devel mailing list