Review Request 118753: Handle mouse wheel in PlasmaComponents.Slider

Sebastian Kügler sebas at kde.org
Mon Jun 16 01:03:21 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118753/#review60153
-----------------------------------------------------------

Ship it!


Ship It!

- Sebastian Kügler


On June 15, 2014, 12:01 a.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118753/
> -----------------------------------------------------------
> 
> (Updated June 15, 2014, 12:01 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> Now that we can handle mouse wheel events with QtQuick 2, we should.
> 
> It mimics QSlider's behavior meaning scrolling vertically up (angleDelta.y > 0) and scrolling horizontally right (angleDelta.x < 0 - though WheelEvent documentation suggests otherwise) is treated the same. Anyone with a mousewheel that can actually scroll sideways is invited to test. Also WheelEvent behaves erratic when scrolling horizontally on my touchpad (reporting 1 digit y values instead of proper x values)
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/plasmacomponents/qml/Slider.qml 142040a 
> 
> Diff: https://git.reviewboard.kde.org/r/118753/diff/
> 
> 
> Testing
> -------
> 
> Tested in a horizontal slider with both mouse and touchpad scrolling with either vertical or (by holding Alt) horizontal scrolling
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140616/9fb2ac8f/attachment.html>


More information about the Plasma-devel mailing list