Review Request 118769: Use RotationAnimator in BusyIndicator

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118769/
-----------------------------------------------------------

(Updated June 15, 2014, 8:30 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma, David Edmundson, Elias Probst, and Jan Grulich.


Bugs: 311799 and 336274
    http://bugs.kde.org/show_bug.cgi?id=311799
    http://bugs.kde.org/show_bug.cgi?id=336274


Repository: plasma-framework


Description
-------

Use RotationAnimator [1] for the BusyIndicator animation which operates directly on the scenegraph.

This helped reducing the massive plasmashell CPU usage during file copying (ie. notifications spinning). The results varied greatly but it can't hurt to use the Animator nonetheless since it doesn't propagate the new rotation angle constantly.

[1] http://qt-project.org/doc/qt-5/qml-qtquick-rotationanimator.html


Diffs
-----

  src/declarativeimports/plasmacomponents/qml/BusyIndicator.qml fafd031 

Diff: https://git.reviewboard.kde.org/r/118769/diff/


Testing
-------

Put notification in panel and systray, requested a view from JobViewServer, ran top. Tried with different configurations, such as LIBGL_ALWAYS_SOFTWARE=1 or QML_FORCE_THREADED_RENDERER=1. Results varied but generally indicated a CPU relief.


Thanks,

Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140615/777b550d/attachment.html>