Review Request 118512: Turn KFileMetaData into a Framework.

Matthew Dawson matthew at mjdsystems.ca
Sat Jun 14 22:20:20 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118512/
-----------------------------------------------------------

(Updated June 14, 2014, 6:20 p.m.)


Review request for Plasma, Jonathan Riddell and Vishesh Handa.


Changes
-------

Replace the renaming effort with the reworking of KFileMetaData into a framework.  Patch for Baloo will follow, and I'll chase down any other failures as I find them/they are pointed out.


Summary (updated)
-----------------

Turn KFileMetaData into a Framework.


Bugs: https://bugs.gentoo.org/show_bug.cgi?id=512334
    http://bugs.kde.org/show_bug.cgi?id=https://bugs.gentoo.org/show_bug.cgi?id=512334


Repository: kfilemetadata


Description (updated)
-------

Turn KFileMetaData into a Framework.


Diffs (updated)
-----

  CMakeLists.txt 5a9eefa89b2fc7e6202347daf105baa867328ffc 
  KF5FileMetaDataConfig.cmake.in PRE-CREATION 
  KFileMetaDataConfig.cmake.in b4d1c93b7a23ffcbb03a89e9d4a11559d7e22037 
  autotests/CMakeLists.txt c657a7002d1d0644d6de4438a193bb63657b7ec0 
  src/CMakeLists.txt 82dbd5c32050081642e9fff958d229f55893d40c 
  src/extractionresult.h 76dfe590aaf1f1fda265a4835fa1bcdbc81ba58a 
  src/extractorplugin.h 218ef207982e31f0142983d75b4846cd0f45f02a 
  src/extractorpluginmanager.h d4a871e7d5952edb48c5836769741d7cf20bd29f 
  src/extractors/CMakeLists.txt 0099c0878315a07f4d7b1369dc1471a8401f10a7 
  src/propertyinfo.h bb54f58c750eff8c39685861a5346c025265949b 
  src/typeinfo.h 2675cbbd5751de9a7ac77cf9fdda4cb6d0a7806e 

Diff: https://git.reviewboard.kde.org/r/118512/diff/


Testing
-------

Tested compiling Baloo against a system install with this patch applied.  Baloo sucessfully linked against the KF5 version and all Baloo tests ran to completion.

All KFileMetaData unit tests passed too ;)


Thanks,

Matthew Dawson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140614/4b11f6ff/attachment.html>


More information about the Plasma-devel mailing list