Review Request 118716: New Translations KCM

[Chusslove Illich]

> On June 13, 2014, 11:53 a.m., Martin Klapetek wrote:
> > kcms/translations/kcmtranslations.cpp, line 49
> > <https://git.reviewboard.kde.org/r/118716/diff/1/?file=280673#file280673line49>
> >
> >     Why are you having John's name translated? ;)
> 
> Chusslove Illich wrote:
>     Because he will be ??? ???? in my language.
> 
> Martin Klapetek wrote:
>     Why's that? And shouldn't email then be also ki18n'd?
> 
> Martin Gräßlin wrote:
>     I also find it strange, but checked in e.g. KWin - there I also found i18n("Martin Gräßlin"), although I think it's impossible to translate my name or write in another alphabet (and no dear US english, it's NOT Grablin ;-)

In the second decade of twenty first century, Review Board ate my Unicode.

Anyway, names may be transliterated, therefore they are always wrapped for
translation. Email addresses are not because... (insert any reasonable
subjective explanation) ...no one asked for that yet.


- Chusslove


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118716/#review59949
-----------------------------------------------------------


On June 13, 2014, 4:31 a.m., Sebastian Kügler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118716/
> -----------------------------------------------------------
> 
> (Updated June 13, 2014, 4:31 a.m.)
> 
> 
> Review request for KDE Frameworks, Plasma, Chusslove Illich, and John Layt.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> This is the second part of the replacement of the Locale KCM: Translations.
> 
> This KCM complements the formats KCM, which sets the locale. With this KCM, the user can configure GUI translations.
> 
> The mechanism to set up the langhere, KF5-uage is the same as in the formats KCM, while formats set LC_* and LANG, this KCM will set LANGUAGE. The UI is roughly the same as in the previous "Locale", though here, KF5-compatible mechanism (QLocale, ki18n, are used.
> 
> This code has been written by John Layt, I've merely cleaned it up a bit, added some missing features, tested it and am submitting it now for review.
> 
> 
> Diffs
> -----
> 
>   kcms/CMakeLists.txt 6bda5434d7d1147c0e8295f2919c17ea59d1be99 
>   kcms/formats/kcmformats.h 345fbb193d327c39fd80d690bdf8f41d3171c6a2 
>   kcms/formats/kcmformats.cpp 4169244f68b4f3c766cae514a8dde4d902cbfee1 
>   kcms/formats/writeexports.h PRE-CREATION 
>   kcms/translations/CMakeLists.txt dd70f47d11e2f3a1359cae2a1306b217af82d848 
>   kcms/translations/Messages.sh 38f48cb32af5ff278bb25b6bef323c546e9223a3 
>   kcms/translations/kcmtranslations.h adc3a48d1b65cbba89d74326eb42c7925a3708b2 
>   kcms/translations/kcmtranslations.cpp 9095fda40ed5c794f06c56ed842bf7861dc88f2e 
>   kcms/translations/kcmtranslationswidget.ui 4ad3242811d3f92acc05d010e120189f681446ad 
>   kcms/translations/translations.desktop ea9086732f7359ba58496d8b60851eca34669c16 
> 
> Diff: https://git.reviewboard.kde.org/r/118716/diff/
> 
> 
> Testing
> -------
> 
> Set up languages (x-test, others), re-logged in, languages correctly set up for KF5 and console applications.
> 
> 
> File Attachments
> ----------------
> 
> KCM in systemsettings
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/06/13/28a00558-f671-4f39-bfe3-ca9dca8e98ce__tranlationskcm.png
> 
> 
> Thanks,
> 
> Sebastian Kügler
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140614/1f9f7ed6/attachment-0001.html>