Review Request 118734: Added MPRIS specifications Tracklist Interface

Ashish Madeti ashishmadeti at gmail.com
Sat Jun 14 08:15:14 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118734/
-----------------------------------------------------------

(Updated June 14, 2014, 1:45 p.m.)


Review request for Plasma, Emmanuel Pescosta, Shantanu Tushar, and Sinny Kumari.


Changes
-------

Fixed the issues


Repository: plasma-mediacenter


Description
-------

Added a MPRIS specifications Tracklist Interface, which will expose and give control over the current playlist on dbus.
http://specifications.freedesktop.org/mpris-spec/latest/Track_List_Interface.html


Diffs (updated)
-----

  libs/mediacenter/CMakeLists.txt 8d95cfc 
  libs/mediacenter/mpris2/mediaplayer2player.h 7a2f583 
  libs/mediacenter/mpris2/mediaplayer2player.cpp 2de56c2 
  libs/mediacenter/mpris2/mediaplayer2tracklist.h PRE-CREATION 
  libs/mediacenter/mpris2/mediaplayer2tracklist.cpp PRE-CREATION 
  libs/mediacenter/mpris2/mpris2.h 1dd78ca 
  libs/mediacenter/mpris2/mpris2.cpp b64ba04 
  shells/newshell/mainwindow.cpp 3c888f8 

Diff: https://git.reviewboard.kde.org/r/118734/diff/


Testing
-------

Tested the properties using qdbusviewer.
I created a qt console application for testing whether the signals are being emitted correctly and the methods are working.


Thanks,

Ashish Madeti

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140614/7205bf77/attachment.html>


More information about the Plasma-devel mailing list