Review Request 118730: [startkde] Introduce a ksyncdbusenv helper application

Martin Gräßlin mgraesslin at kde.org
Fri Jun 13 19:36:31 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118730/
-----------------------------------------------------------

(Updated June 13, 2014, 9:36 p.m.)


Review request for Plasma and David Edmundson.


Changes
-------

* removed QDBusWatcher
* fixed install path
* startkde checks whether the tool succeeded and aborts on failure (unsure about it, but it helped A LOT debugging the error)


Repository: plasma-workspace


Description
-------

[startkde] Introduce a ksyncdbusenv helper application

This application is invoked by startkde once all environment variables
are set and syncs them to DBus for the activation environment.


Diffs (updated)
-----

  startkde/startkde.cmake 0c1f5841eeefc1012dbdc71e1d1fde11e7511dd6 
  startkde/ksyncdbusenv/ksyncdbusenv.cpp PRE-CREATION 
  startkde/ksyncdbusenv/CMakeLists.txt PRE-CREATION 
  startkde/CMakeLists.txt 3360a1c59409588ecec49e63276914b69568164e 

Diff: https://git.reviewboard.kde.org/r/118730/diff/


Testing
-------

on log in kglobalacceld5 doesn't pick up the right environment yet, but on manual invocation of the tool + trigger restart of kglobalacceld5 it works. So the approach seems to work, just not yet from startkde (maybe it's too late?)


Thanks,

Martin Gräßlin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140613/7c9f0956/attachment-0001.html>


More information about the Plasma-devel mailing list