Review Request 115431: Fix the numbers cut off problem in digital clock applet

[Yichao Zhou]

> On June 13, 2014, 11:55 a.m., Sebastian Kügler wrote:
> > To be honest, I'm not really sold on this font metric magic you're doing here.
> > 
> > Could you attach screenshots old/new with different fonts? Perhaps some, with which the problem is well visible, one with it being hardly visible, and of course a default?

Thanks for the comment.  But for now I need to prepare for the final exam.  I will handle this in a week.


- Yichao


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115431/#review59970
-----------------------------------------------------------


On March 18, 2014, 12:56 p.m., Yichao Zhou wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115431/
> -----------------------------------------------------------
> 
> (Updated March 18, 2014, 12:56 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 228902
>     http://bugs.kde.org/show_bug.cgi?id=228902
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> -------
> 
> For bug, see
> https://bugs.launchpad.net/ubuntu/+source/kde-workspace/+bug/1052059 and
> https://bugs.kde.org/show_bug.cgi?id=228902
> 
> The problem is that in original code, it always uses 23:59 to calculate the width of the text.  However, in some font, AM is wider than PM, and 0 is wider than 2 and 5.  That causes some fonts been cropped.
> 
> 
> Diffs
> -----
> 
>   plasma/generic/applets/digital-clock/clock.cpp f26e328 
> 
> Diff: https://git.reviewboard.kde.org/r/115431/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Yichao Zhou
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140613/2b46e9ba/attachment-0001.html>