Review Request 118730: [startkde] Introduce a ksyncdbusenv helper application

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118730/#review59985
-----------------------------------------------------------



startkde/ksyncdbusenv/ksyncdbusenv.cpp
<https://git.reviewboard.kde.org/r/118730/#comment41764>

    for (auto i = map.constBegin(); i != map.constEnd(); ++i)
        env.insert(i.key(), i.value());
    
    
    is faster here as you're not doing a hash lookup each time.



startkde/ksyncdbusenv/ksyncdbusenv.cpp
<https://git.reviewboard.kde.org/r/118730/#comment41765>

    you may as well make this synchronous and lose the app.exec()
    
    you'd still get 1 event loop and it'd be easier to read.


- David Edmundson


On June 13, 2014, 1:01 p.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118730/
> -----------------------------------------------------------
> 
> (Updated June 13, 2014, 1:01 p.m.)
> 
> 
> Review request for Plasma and David Edmundson.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> [startkde] Introduce a ksyncdbusenv helper application
> 
> This application is invoked by startkde once all environment variables
> are set and syncs them to DBus for the activation environment.
> 
> 
> Diffs
> -----
> 
>   startkde/CMakeLists.txt 3360a1c59409588ecec49e63276914b69568164e 
>   startkde/ksyncdbusenv/CMakeLists.txt PRE-CREATION 
>   startkde/ksyncdbusenv/ksyncdbusenv.cpp PRE-CREATION 
>   startkde/startkde.cmake 0c1f5841eeefc1012dbdc71e1d1fde11e7511dd6 
> 
> Diff: https://git.reviewboard.kde.org/r/118730/diff/
> 
> 
> Testing
> -------
> 
> on log in kglobalacceld5 doesn't pick up the right environment yet, but on manual invocation of the tool + trigger restart of kglobalacceld5 it works. So the approach seems to work, just not yet from startkde (maybe it's too late?)
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140613/304e65f4/attachment.html>