Review Request 118730: [startkde] Introduce a ksyncdbusenv helper application

David Edmundson david at davidedmundson.co.uk
Fri Jun 13 13:14:48 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118730/#review59979
-----------------------------------------------------------


I don't understand where this is useful unless you have a broken setup to begin with.

Either you have your XDG paths set up properly for all users at which point you don't need this.
Or you have DBus setup to load apps with a missing env, which is clearly a silly thing to do.

This patch will make things to work in the Plasma 5 env; but it'll still be broken if you ran this from other desktops which makes the setup wrong.

- David Edmundson


On June 13, 2014, 1:01 p.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118730/
> -----------------------------------------------------------
> 
> (Updated June 13, 2014, 1:01 p.m.)
> 
> 
> Review request for Plasma and David Edmundson.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> [startkde] Introduce a ksyncdbusenv helper application
> 
> This application is invoked by startkde once all environment variables
> are set and syncs them to DBus for the activation environment.
> 
> 
> Diffs
> -----
> 
>   startkde/CMakeLists.txt 3360a1c59409588ecec49e63276914b69568164e 
>   startkde/ksyncdbusenv/CMakeLists.txt PRE-CREATION 
>   startkde/ksyncdbusenv/ksyncdbusenv.cpp PRE-CREATION 
>   startkde/startkde.cmake 0c1f5841eeefc1012dbdc71e1d1fde11e7511dd6 
> 
> Diff: https://git.reviewboard.kde.org/r/118730/diff/
> 
> 
> Testing
> -------
> 
> on log in kglobalacceld5 doesn't pick up the right environment yet, but on manual invocation of the tool + trigger restart of kglobalacceld5 it works. So the approach seems to work, just not yet from startkde (maybe it's too late?)
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140613/e82f2d74/attachment.html>


More information about the Plasma-devel mailing list