Review Request 118657: Use move() while moving items in playlist, instead of dataChanged() signals

Shantanu Tushar shantanu at kde.org
Wed Jun 11 16:27:56 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118657/#review59816
-----------------------------------------------------------

Ship it!


Ship It!

- Shantanu Tushar


On June 11, 2014, 5:51 a.m., Ashish Madeti wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118657/
> -----------------------------------------------------------
> 
> (Updated June 11, 2014, 5:51 a.m.)
> 
> 
> Review request for Plasma, Shantanu Tushar and Sinny Kumari.
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> -------
> 
> Use beginMoveRows() and endMoveRows() instead of dataChanged() while moving items in playlistModel
> 
> 
> Diffs
> -----
> 
>   libs/mediacenter/playlistmodel.cpp 158ca65 
> 
> Diff: https://git.reviewboard.kde.org/r/118657/diff/
> 
> 
> Testing
> -------
> 
> Moved media around in playlist, its working fine.
> 
> 
> Thanks,
> 
> Ashish Madeti
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140611/2f3511b1/attachment.html>


More information about the Plasma-devel mailing list