Review Request 118388: rename systemsettings binary to systemsettings5

[Sebastian Kügler]

> On June 9, 2014, 1:21 p.m., Eike Hein wrote:
> > If you rename the .desktop files, please remember to update the default favorites configurations in Kicker (it's in the main.xml of the package) and Kickoff (somewhere in C++ model code) since they both reference System Settings by KService storage id.
> 
> Hrvoje Senjan wrote:
>     at least in this review, no rename of the desktop files would be done.
>     but speaking of favorites, looks like kickoff has the wrong one (kdesystemsettings is usually used outside KDE session)

I've fixed that, well spot!


- Sebastian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118388/#review59612
-----------------------------------------------------------


On May 28, 2014, 7:32 p.m., Hrvoje Senjan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118388/
> -----------------------------------------------------------
> 
> (Updated May 28, 2014, 7:32 p.m.)
> 
> 
> Review request for Plasma and Ben Cooksley.
> 
> 
> Repository: systemsettings
> 
> 
> Description
> -------
> 
> while workspace might not be targeted to co-exist with 4.x variant - systemsettings should IMHO be able to co-exist. not only workspace components are adjusting in there, and telling people to do kcmshell$notinstalledvariant $wantedkcm is very user-unfriendly...
> one TODO if this gets a green light, is to rename desktop files, so people know which variant they are opening.
> 
> 
> Diffs
> -----
> 
>   app/systemsettings.desktop 5f27318 
>   app/kdesystemsettings.desktop 946d498 
>   app/CMakeLists.txt c45f7e7 
> 
> Diff: https://git.reviewboard.kde.org/r/118388/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Hrvoje Senjan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140611/08c53fa5/attachment-0001.html>