Review Request 118468: Use the spacebar key to play/pause a media from the homescreen.

[R.Harish Navnit]

> On June 2, 2014, 5:05 p.m., Shantanu Tushar wrote:
> > Hmm, looks good to me.

If this is fine, can this change be committed on my behalf ? 

Thanks. 


- R.Harish


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118468/#review59005
-----------------------------------------------------------


On June 2, 2014, 12:24 p.m., R.Harish  Navnit wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118468/
> -----------------------------------------------------------
> 
> (Updated June 2, 2014, 12:24 p.m.)
> 
> 
> Review request for Plasma, Shantanu Tushar and Sinny Kumari.
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> -------
> 
> As of now, PMC only uses the MediaPlay button to give the user an option to play/pause media from the home screen. However, not all keyboards have the MediaPlay button AFAIK. 
> This patch gives the user the option to play/pause the media from the home screen using the spacebar key as another alternative. 
> 
> 
> Diffs
> -----
> 
>   shells/newshell/package/contents/ui/mediacenter.qml e1bc0e6 
> 
> Diff: https://git.reviewboard.kde.org/r/118468/diff/
> 
> 
> Testing
> -------
> 
> Play any media, navigate to homescreen. Press the spacebar to check if the media plays/pauses. 
> 
> Seems to work fine to me. 
> 
> 
> Thanks,
> 
> R.Harish  Navnit
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140611/33ce9da3/attachment.html>