Review Request 118251: Small improvments to FadingNode and IconItem
David Edmundson
david at davidedmundson.co.uk
Tue Jun 10 20:37:14 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118251/#review59724
-----------------------------------------------------------
Ship it!
Ship It!
- David Edmundson
On June 10, 2014, 1:56 p.m., Martin Gräßlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118251/
> -----------------------------------------------------------
>
> (Updated June 10, 2014, 1:56 p.m.)
>
>
> Review request for Plasma and David Edmundson.
>
>
> Repository: plasma-framework
>
>
> Description
> -------
>
> Small improvments to FadingNode and IconItem
>
> * trigger an update after the animation finished as the IconItem needs to
> switch to SVGTextureNode again
> * Don't connect needlessly to a lambda slot
> * FadingMaterialShader had the texture bind swapped
> * Fix virtual method hidden warning in FadingMaterialShader
> * Use dynamic_cast instead of static_cast to convert to SVGTextureNode
> or FadingNode.
>
>
> Diffs
> -----
>
> src/declarativeimports/core/fadingnode.cpp 207eff3902848a3c76bf1ec62d73877d6d9d0df7
> src/declarativeimports/core/iconitem.cpp 384017d4a9c9a96e1d465298260dffe0285712e3
>
> Diff: https://git.reviewboard.kde.org/r/118251/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Martin Gräßlin
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140610/ed54c53d/attachment.html>
More information about the Plasma-devel
mailing list