Review Request 118644: Update battery monitor popup to use new icons

[Andrew Lake]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118644/
-----------------------------------------------------------

(Updated June 10, 2014, 5:09 p.m.)


Review request for Plasma and Kai Uwe Broulik.


Changes
-------

oops added two copies of the svg theme file


Repository: plasma-workspace


Description
-------

Update battery monitor to use new icons from new battery.svgz theme file in popup.

Also includes minor updates to vertical alignments of icon with text and slight increase in battery status text opacity.

(Requires replacing the battery.svgz theme file in the theme icons/ directory with the new one attached - I wasn't sure how to do a review request across two different repos)


Diffs
-----

  applets/batterymonitor/contents/ui/BatteryIcon.qml 308eaf85c8d41574f210086b6ce17a47e261a773 
  applets/batterymonitor/contents/ui/BatteryItem.qml 655026b83333e5a429f70e55aa8b9d01218139ac 
  applets/batterymonitor/contents/ui/BrightnessItem.qml 0d7e8e2b4a2acae4e5a2ab43a9edefc812216ee6 
  applets/batterymonitor/contents/ui/PopupDialog.qml 44f6f9dd55d6356c446f4c7352bc5bc03338d870 

Diff: https://git.reviewboard.kde.org/r/118644/diff/


Testing
-------


File Attachments (updated)
----------------

New battery.svgz theme file
  https://git.reviewboard.kde.org/media/uploaded/files/2014/06/10/1b839cb5-f507-42c0-9314-cd9e0a17ee1f__battery.svgz
SS from my laptop
  https://git.reviewboard.kde.org/media/uploaded/files/2014/06/10/6bb20e04-22fd-4ad6-bff6-9afee5cfd4de__iconsreviewrequestss.png
icon assets shown in mockup
  https://git.reviewboard.kde.org/media/uploaded/files/2014/06/10/102356b1-0d85-45fa-96de-93384e444433__mockup_battery_monitor_2.png


Thanks,

Andrew Lake

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140610/75d09022/attachment.html>