Review Request 118423: [klipper] Port KMimeType to QMimeType
Martin Klapetek
martin.klapetek at gmail.com
Tue Jun 10 10:29:30 UTC 2014
> On June 10, 2014, 12:26 p.m., David Edmundson wrote:
> > klipper/urlgrabber.cpp, line 152
> > <https://git.reviewboard.kde.org/r/118423/diff/2/?file=276481#file276481line152>
> >
> > QLatin1String
> >
> > (or rather QStringLiteral)
For string comparisons QLatin1String is better/faster/less memory.
- Martin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118423/#review59657
-----------------------------------------------------------
On May 30, 2014, 3:38 p.m., Martin Gräßlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118423/
> -----------------------------------------------------------
>
> (Updated May 30, 2014, 3:38 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> [klipper] Port KMimeType to QMimeType
>
>
> Diffs
> -----
>
> klipper/urlgrabber.cpp 4eccb7065ae2932cc548c902ab3a8c50e4972444
>
> Diff: https://git.reviewboard.kde.org/r/118423/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Martin Gräßlin
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140610/9ffef4ab/attachment.html>
More information about the Plasma-devel
mailing list