Review Request 118613: Prevent crash when requesting icon with negative size

[David Edmundson]

> On June 8, 2014, 9:52 a.m., Martin Klapetek wrote:
> > src/declarativeimports/core/iconitem.cpp, lines 295-296
> > <https://git.reviewboard.kde.org/r/118613/diff/1/?file=279629#file279629line295>
> >
> >     Unrelated general question - why is there m_iconPixmap and m_pixmapIcon and what's the difference?
> 
> David Edmundson wrote:
>     one exists, the other doesn't.
>     
>     BShah, can you remove this commented line. It doesn't add to anything.
> 
> Martin Klapetek wrote:
>     No, they both do exist and are used. Look through the source code and .h file

oh, I meant the m_iconPixmaps, the commented code.

As for your comment: 
 - one is the pixmap supplied by the user
 - one is the final resultant pixmap to display

For the case of a pixmap it's a direct copy. In the old code one it probably scaled. For others the SVGs render into the resultant pixmap.

I agree it's a bit confusingly named 


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118613/#review59545
-----------------------------------------------------------


On June 8, 2014, 4:45 a.m., Bhushan Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118613/
> -----------------------------------------------------------
> 
> (Updated June 8, 2014, 4:45 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 335939
>     http://bugs.kde.org/show_bug.cgi?id=335939
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> Prevent crash when requesting icon with negative size.
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/core/iconitem.cpp 9e0cb36 
> 
> Diff: https://git.reviewboard.kde.org/r/118613/diff/
> 
> 
> Testing
> -------
> 
> tried to resize some icons.. no longer crashes
> 
> 
> Thanks,
> 
> Bhushan Shah
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140608/8075a683/attachment.html>