Review Request 118613: Prevent crash when requesting icon with negative size

David Edmundson david at davidedmundson.co.uk
Sun Jun 8 09:49:52 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118613/#review59544
-----------------------------------------------------------

Ship it!


Ship It!

- David Edmundson


On June 8, 2014, 4:45 a.m., Bhushan Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118613/
> -----------------------------------------------------------
> 
> (Updated June 8, 2014, 4:45 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 335939
>     http://bugs.kde.org/show_bug.cgi?id=335939
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> Prevent crash when requesting icon with negative size.
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/core/iconitem.cpp 9e0cb36 
> 
> Diff: https://git.reviewboard.kde.org/r/118613/diff/
> 
> 
> Testing
> -------
> 
> tried to resize some icons.. no longer crashes
> 
> 
> Thanks,
> 
> Bhushan Shah
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140608/13a064e0/attachment.html>


More information about the Plasma-devel mailing list