Review Request 118592: Fix Plasma's SNI icons + port away from kdelibs4support

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118592/#review59452
-----------------------------------------------------------

Ship it!


+1 for that

- Marco Martin


On June 6, 2014, 1:28 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118592/
> -----------------------------------------------------------
> 
> (Updated June 6, 2014, 1:28 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> This is the final patch required for Qt4 SNI icons with custom themes to work properly. Also ports away from kdelibs4support bits.
> 
> 
> Diffs
> -----
> 
>   applets/systemtray/plugin/protocols/dbussystemtray/dbussystemtraytask.cpp 570f54e 
>   dataengines/statusnotifieritem/CMakeLists.txt d5f0a34 
>   dataengines/statusnotifieritem/statusnotifieritem_engine.cpp 70d203e 
>   dataengines/statusnotifieritem/statusnotifieritemsource.cpp 2157def 
> 
> Diff: https://git.reviewboard.kde.org/r/118592/diff/
> 
> 
> Testing
> -------
> 
> Qt4 apps with the QSystrayIcon-to-SNI patch now have proper icons in our systray --> http://i.imgur.com/V5ixOyf.png
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140606/40ca50cc/attachment.html>