Review Request 118584: Formats KCM: Use QLocale::name() instead of bcp47Name() when writing to the configuration file

[Sebastian Kügler]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118584/#review59407
-----------------------------------------------------------


I'd like to hear John's take on this. IIRC, bcp47Name() is the correct one to use here. (Which leaves questions indeed.)

- Sebastian Kügler


On June 6, 2014, 6:45 a.m., Luca Beltrame wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118584/
> -----------------------------------------------------------
> 
> (Updated June 6, 2014, 6:45 a.m.)
> 
> 
> Review request for Plasma, John Layt and Sebastian Kügler.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> Currently the Formats KCM writes its configuration file using the selected locale's bcp47Name(). This, at least on my distro, breaks locale loading as locales are in the form "foo_FOO" (e.g., "it_IT" for my own locale) and instead the Formats KCM exports LANG as "foo" (e.g. "it").
> 
> This causes a bunch of runtime warnings and locales don't get actually loaded. This patch's approach is naive and likely needs more pairs of eyes on it, as I can't test with other distros.
> 
> Also we might need "UTF-8" suffix for distros that use UTF-8 locales: or so I think, but I'm not knowledgeable enough to tell if this is needed or not.
> 
> 
> Diffs
> -----
> 
>   kcms/formats/kcmformats.cpp 4169244 
> 
> Diff: https://git.reviewboard.kde.org/r/118584/diff/
> 
> 
> Testing
> -------
> 
> Compiled, ran the Formats KCM, selected my country, inspected the generated files.
> 
> 
> Thanks,
> 
> Luca Beltrame
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140606/b8dc8d8c/attachment.html>