Review Request 118573: Some tweaks in the logout screen

[Marco Martin]

> On June 5, 2014, 10:23 p.m., Aleix Pol Gonzalez wrote:
> > ksmserver/shutdowndlg.cpp, line 85
> > <https://git.reviewboard.kde.org/r/118573/diff/1/?file=279220#file279220line85>
> >
> >     I'm unsure what's the issue here.
> 
> Martin Gräßlin wrote:
>     this might break the logout effect

Seems it works fine


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118573/#review59363
-----------------------------------------------------------


On June 5, 2014, 7:02 p.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118573/
> -----------------------------------------------------------
> 
> (Updated June 5, 2014, 7:02 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> This does two things:
> * some tweaks in the logout theme, partly inverts theme colors and makes the logout/shutdown toolbuttons a group of 3 always visible exclusive-toggle buttons
> * add the flag bypasswindowmanagerhint to the main logout window: seems the only way here to obtain the proper size and position
> 
> (old screenshot to give the idea: http://wstaw.org/m/2014/06/05/plasma-desktopGg1731.png labels are actually of the proper color now)
> 
> 
> Diffs
> -----
> 
>   ksmserver/shutdowndlg.cpp 68efcf6 
>   lookandfeel/contents/components/BreezeBlock.qml 4093f5f 
>   lookandfeel/contents/components/LogoutScreen.qml 1f7825d 
> 
> Diff: https://git.reviewboard.kde.org/r/118573/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140606/47550cf4/attachment.html>