Review Request 118573: Some tweaks in the logout screen

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118573/#review59363
-----------------------------------------------------------



ksmserver/shutdowndlg.cpp
<https://git.reviewboard.kde.org/r/118573/#comment41317>

    I'm unsure what's the issue here.



lookandfeel/contents/components/LogoutScreen.qml
<https://git.reviewboard.kde.org/r/118573/#comment41315>

    I suggest to create a BreezeLabel component in the components folder and use it. There are other labels that will have to be changed.
    
    Same thing with Heading.



lookandfeel/contents/components/LogoutScreen.qml
<https://git.reviewboard.kde.org/r/118573/#comment41316>

    This has to be changed as well in the LockScreen.
    
    This button row should be probably its own component as well, but I can do that tomorrow.


- Aleix Pol Gonzalez


On June 5, 2014, 7:02 p.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118573/
> -----------------------------------------------------------
> 
> (Updated June 5, 2014, 7:02 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> This does two things:
> * some tweaks in the logout theme, partly inverts theme colors and makes the logout/shutdown toolbuttons a group of 3 always visible exclusive-toggle buttons
> * add the flag bypasswindowmanagerhint to the main logout window: seems the only way here to obtain the proper size and position
> 
> (old screenshot to give the idea: http://wstaw.org/m/2014/06/05/plasma-desktopGg1731.png labels are actually of the proper color now)
> 
> 
> Diffs
> -----
> 
>   ksmserver/shutdowndlg.cpp 68efcf6 
>   lookandfeel/contents/components/BreezeBlock.qml 4093f5f 
>   lookandfeel/contents/components/LogoutScreen.qml 1f7825d 
> 
> Diff: https://git.reviewboard.kde.org/r/118573/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140605/305454cf/attachment.html>