Review Request 118548: Port libtaskmanager away from QDesktopWidget

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118548/
-----------------------------------------------------------

(Updated June 5, 2014, 4:57 p.m.)


Review request for Plasma, Martin Gräßlin, Eike Hein, and Luca Beltrame.


Changes
-------

Note this shouldn't prevent this patch from going in, but: Martin, can you please consult on the code in TaskManager::isOnScreen()? It fudges window geometry by removing 5 pixels from each side of the rect with a note about window decoration overscan. This is likely ancient code, is it still relevant today to do this?


Repository: plasma-workspace


Description
-------

plasmoid.screen doesn't map to QDesktopWidget indexes anymore, therefore we need to port it.

This patch uses the screen geometry to figure out what's the screen and then passes around the screen rect so that we can filter out the screens that aren't inside if the user asks for it.


Diffs
-----

  libtaskmanager/taskmanager.cpp 27eeed7 
  libtaskmanager/taskmanager.h e6ca735 
  libtaskmanager/task.h 13a5a9c 
  libtaskmanager/task.cpp 50ea1a6 
  libtaskmanager/launcheritem.cpp 649caca 
  libtaskmanager/groupmanager.h aa71bac 
  libtaskmanager/groupmanager.cpp 83b39ef 

Diff: https://git.reviewboard.kde.org/r/118548/diff/


Testing
-------

I have played with it and seems to work.


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140605/177495cc/attachment.html>