Review Request 117433: [applets/notifications] Use ::hide() instead of ::close()

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117433/
-----------------------------------------------------------

(Updated June 5, 2014, 2:25 p.m.)


Status
------

This change has been discarded.


Review request for Plasma and Martin Klapetek.


Repository: plasma-workspace


Description
-------

[applets/notifications] Use ::hide() instead of ::close()

QWindow::close() is destroying the window directly, while ::hide() just
unmaps the window. The main difference is that with hide() the window
manager can still access the x window in the close handling and with
close that's not possible and KWin generates runtime errors.

@MartinK: was there a specific reason to use QWindow::close()? Will using hide() cause problems?


Diffs
-----

  applets/notifications/package/contents/ui/NotificationPopup.qml f738e000b4a28c8c43cbbb9410a53f8b34e4fc56 
  applets/notifications/plugin/notificationshelper.cpp 9cc119151232d244b4a05d89f07069a80b1da96c 

Diff: https://git.reviewboard.kde.org/r/117433/diff/


Testing
-------

KWin doesn't print warnings when a notification closes.


Thanks,

Martin Gräßlin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140605/e9de796d/attachment.html>