Review Request 118557: Port PlasmaFramework to i18nd + Add test checking for i18n use

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118557/#review59301
-----------------------------------------------------------

Ship it!


Ship It!

- Marco Martin


On June 5, 2014, 10:12 a.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118557/
> -----------------------------------------------------------
> 
> (Updated June 5, 2014, 10:12 a.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> Set catalog name in QueryDailog
> 
> Add a test that i18nd is used throughout
> 
> I know I'm definitely going to forget to use i18nd in the near future, I'm sure others will too.
> The test is somewhat naive, (it would fail if you write i18n() in a comment for example), but I think it's going to catch a lot more problems than it causes.
> 
> 
> Diffs
> -----
> 
>   autotests/CMakeLists.txt cda9f03 
>   autotests/i18ndcheck.sh PRE-CREATION 
>   src/declarativeimports/plasmacomponents/qml/QueryDialog.qml a057e72 
> 
> Diff: https://git.reviewboard.kde.org/r/118557/diff/
> 
> 
> Testing
> -------
> 
> Tests pass.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140605/869b87c1/attachment.html>