Review Request 118547: Expose Formats as singleton

[David Edmundson]

> On June 5, 2014, 3:44 a.m., Bhushan Shah wrote:
> > src/qmlcontrols/kcoreaddons/kcoreaddonsplugin.cpp, line 40
> > <https://git.reviewboard.kde.org/r/118547/diff/1/?file=278948#file278948line40>
> >
> >     Err no, this will fail when using formatRelativeDate and formatRelativeDateTime

good catch. That was an accidental delete


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118547/#review59261
-----------------------------------------------------------


On June 5, 2014, 12:03 a.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118547/
> -----------------------------------------------------------
> 
> (Updated June 5, 2014, 12:03 a.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: kdeclarative
> 
> 
> Description
> -------
> 
> Expose Formats as singleton
> 
> Formats is basically just a collection of invokable static methods.
> This saves creating a few objects and makes for a a nicer API.
> 
> Without it you have to have a bit of code like:
> 
> -    KCoreAddons.Formats {
> -        id: formats
> -    }
> then do text:formats.formatData(...) in your labels
> 
> this becomes now
> 
> KCoreAddons.Format.formatData(...) 
> 
> 
> Diffs
> -----
> 
>   src/qmlcontrols/kcoreaddons/kcoreaddonsplugin.cpp 65dd75f 
> 
> Diff: https://git.reviewboard.kde.org/r/118547/diff/
> 
> 
> Testing
> -------
> 
> Made the two changes needed in plasma-workspace. Everything seemed to be ok.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140605/341eafef/attachment.html>