Review Request 118540: Two patches required to build kde-cli-tools 20140603 snapshot on top of KDE Frameworks 4.100.0

[Aleix Pol Gonzalez]

> On June 4, 2014, 11:16 p.m., Aleix Pol Gonzalez wrote:
> > Ship It!
> 
> Eric Hameleers wrote:
>     Errr....?

It's a good patch and it can go in, do you have commit rights or do you want me to push it for you?


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118540/#review59252
-----------------------------------------------------------


On June 4, 2014, 8:13 p.m., Eric Hameleers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118540/
> -----------------------------------------------------------
> 
> (Updated June 4, 2014, 8:13 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kde-cli-tools
> 
> 
> Description
> -------
> 
> Two patches were required to build a kde-cli-tools 20140603 snapshot successfully on top of KDE Frameworks 4.100.0
> 
> 
> Diffs
> -----
> 
>   kdesu/kdesu.cpp d5c7f72 
>   kioclient/kioclient.cpp 71b11fb 
>   kreadconfig/kreadconfig.cpp 532d077 
>   kreadconfig/kwriteconfig.cpp e5597d3 
> 
> Diff: https://git.reviewboard.kde.org/r/118540/diff/
> 
> 
> Testing
> -------
> 
> Slackware-current x86_64
> 
> 
> File Attachments
> ----------------
> 
> kde-cli-tools_ecm.patch
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/06/04/3e33b7c2-9ac5-4bdc-8626-cc9ba9fda401__kde-cli-tools_ecm.patch
> 
> 
> Thanks,
> 
> Eric Hameleers
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140604/bb6e0488/attachment.html>