Review Request 118406: Notify the user if the location containing the media is inaccessible.

[Shantanu Tushar]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118406/#review59209
-----------------------------------------------------------



mediaelements/mediaplayer/MediaPlayer.qml
<https://git.reviewboard.kde.org/r/118406/#comment41223>

    Remove the trailing space in the i18n call (after location).
    
    Also, the i18n on video.source is of no use, people cant translate filenames, can they? :P



mediaelements/mediaplayer/MediaPlayer.qml
<https://git.reviewboard.kde.org/r/118406/#comment41222>

    instead of guessing, why not use the error property of QML Video? http://doc.qt.digia.com/qtmobility-1.2.0/qml-video.html#error-prop


- Shantanu Tushar


On June 3, 2014, 5:05 p.m., R.Harish  Navnit wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118406/
> -----------------------------------------------------------
> 
> (Updated June 3, 2014, 5:05 p.m.)
> 
> 
> Review request for Plasma, Shantanu Tushar and Sinny Kumari.
> 
> 
> Bugs: 333764
>     http://bugs.kde.org/show_bug.cgi?id=333764
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> -------
> 
> If a media(in a playlist) is located in an inaccessible location, then the user is notified about the same. 
> 
> 
> Diffs
> -----
> 
>   mediaelements/mediaplayer/MediaPlayer.qml 98f1d2c 
> 
> Diff: https://git.reviewboard.kde.org/r/118406/diff/
> 
> 
> Testing
> -------
> 
> 1. Load media to a playlist.
> 2. Unmount the device containing media.
> 3. Check if the user is notified of the location being inaccessible
>    --yes, the user is notified
> 4. Mount the device containing media and play a media from playlist.
>    -- The media plays properly.
> 
> 
> Thanks,
> 
> R.Harish  Navnit
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140604/814f52d8/attachment-0001.html>