Review Request 118506: Plasma Active: Adjust the image package for the Plasma Active
Antonis Tsiapaliokas
antonis.tsiapaliokas at kde.org
Wed Jun 4 11:30:39 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118506/
-----------------------------------------------------------
(Updated June 4, 2014, 11:30 a.m.)
Review request for Plasma.
Changes
-------
* Remove the name of the wallpaper.
* And fix the proportions of the thumbnail
Repository: plasma-workspace
Description
-------
This patch adds a new UI for image package on the Plasma Active.
In order to test it you can use "PLASMA_PLATFORM=touch plasmashell -p org.kde.plasma.active".
Diffs (updated)
-----
wallpapers/image/backgroundlistmodel.h 64417a3
wallpapers/image/backgroundlistmodel.cpp 439c642
wallpapers/image/imagepackage/platformcontents/touch/ui/WallpaperDelegate.qml PRE-CREATION
wallpapers/image/imagepackage/platformcontents/touch/ui/config.qml PRE-CREATION
wallpapers/image/imageplugin.cpp 876fd8d
Diff: https://git.reviewboard.kde.org/r/118506/diff/
Testing
-------
Everything looks normal except from the "dotRow".
Despite the fact that the "dotRow" changes, the view of the ListView remains the same.
So you cannot see the rest of the wallpapers.
File Attachments
----------------
wallpaper_with_dotRow
https://git.reviewboard.kde.org/media/uploaded/files/2014/06/03/06ef2797-b119-43c6-a4db-0bde63f674c5__wallapers_active.png
wallpapers_without_dotRow
https://git.reviewboard.kde.org/media/uploaded/files/2014/06/03/124bdfd6-649e-4bb2-9786-3a7723acd576__wallapers_active_fullscreen.png
Thanks,
Antonis Tsiapaliokas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140604/5fa0225f/attachment.html>
More information about the Plasma-devel
mailing list