Review Request 118482: Adjust ksmserver for renamed KWin binary
Hrvoje Senjan
hrvoje.senjan at gmail.com
Wed Jun 4 08:56:02 UTC 2014
> On June 4, 2014, 9:04 a.m., Martin Gräßlin wrote:
> > looks good to me. Where is the KCM living where one can select the window manager?
it is in plasma-desktop repo. but i did not want to add a patch for something that does not build ;-)
1) uses Q_WS_X11 (easy to change)
2) there's some NETRootInfo usage which got change, and i'd rather leave the port to an expert
- Hrvoje
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118482/#review59121
-----------------------------------------------------------
On June 3, 2014, 3:22 p.m., Hrvoje Senjan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118482/
> -----------------------------------------------------------
>
> (Updated June 3, 2014, 3:22 p.m.)
>
>
> Review request for Plasma and Martin Gräßlin.
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> as per dependant review, adjust ksmserver usage of KWin name. (IOW make sure kwin_x11 is started)
>
>
> Diffs
> -----
>
> ConfigureChecks.cmake 8e6a87a
> ksmserver/config-ksmserver.h.cmake 939632c
> ksmserver/server.cpp 644013b
> ksmserver/startup.cpp 6f5d502
>
> Diff: https://git.reviewboard.kde.org/r/118482/diff/
>
>
> Testing
> -------
>
> using it for some ~10 days, noticed no regression.
>
>
> Thanks,
>
> Hrvoje Senjan
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140604/eacaba70/attachment.html>
More information about the Plasma-devel
mailing list