Review Request 118487: fix type issue with qreal
Aleix Pol Gonzalez
aleixpol at kde.org
Tue Jun 3 12:13:50 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118487/#review59081
-----------------------------------------------------------
Ship it!
Ship It!
- Aleix Pol Gonzalez
On June 3, 2014, 12:06 p.m., Harald Sitter wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118487/
> -----------------------------------------------------------
>
> (Updated June 3, 2014, 12:06 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-framework
>
>
> Description
> -------
>
> floor() returns double, qreal is a typedef and could be float (for example), so running a qmax(qreal, floor) may cause build failures
>
>
> Diffs
> -----
>
> src/declarativeimports/core/framesvgitem.cpp def17ea551340e952ce1a9c52d8e7df308b2b8f1
> src/declarativeimports/core/svgitem.cpp c0f30058f68bbfc78ef12477cb85c0159e43909c
>
> Diff: https://git.reviewboard.kde.org/r/118487/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Harald Sitter
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140603/a432d87e/attachment.html>
More information about the Plasma-devel
mailing list