Review Request 118038: Bring back a KCM for the screen locker

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118038/
-----------------------------------------------------------

(Updated June 3, 2014, 8:53 a.m.)


Review request for Plasma and Thomas Pfeiffer.


Changes
-------

* added Messages.sh
* reconfigure KSLD through DBus
* adjust config values to UI
 ** timeout stored in minutes (used to be seconds)
 ** grace time stored in seconds (used to be msec)
 ** lock enabled by default


Repository: plasma-workspace


Description (updated)
-------

Bring back a KCM for the screen locker

Together with adding back the KCM the settings are slightly adjusted to
have them fit the UI without needing a transformation in the KCM.

* timeout is stored in minutes (used to be seconds)
* grace time is stored in seconds (used to be msec)
* lock is enabled by default

Also disabling the locking after idle timeout is no longer possible. An
endless grace made some sense with the screensavers, but not with the
screenlocker. In order to not break an unknown but maybe valid use case
the option is still available, just not exposed through UI.

REVIEW: 118038


Diffs (updated)
-----

  ksmserver/screenlocker/CMakeLists.txt 486563720cfd9af59f1ae2f06a0b9ff4a3c96ea8 
  ksmserver/screenlocker/kcfg/kscreenlockersettings.kcfg 18a12935e127aad75fcf72213f8e34c25a8ed16c 
  ksmserver/screenlocker/kcm/CMakeLists.txt PRE-CREATION 
  ksmserver/screenlocker/kcm/Messages.sh PRE-CREATION 
  ksmserver/screenlocker/kcm/kcm.cpp PRE-CREATION 
  ksmserver/screenlocker/kcm/kcm.ui PRE-CREATION 
  ksmserver/screenlocker/kcm/screenlocker.desktop PRE-CREATION 
  ksmserver/screenlocker/ksldapp.cpp eff9d8d7d7a661a2eac9bf76196380816951bd7a 

Diff: https://git.reviewboard.kde.org/r/118038/diff/


Testing
-------


File Attachments
----------------

KCM with values
  https://git.reviewboard.kde.org/media/uploaded/files/2014/05/07/f70f34d6-2c5c-4638-8e43-d9d727fdb7cb__kcm-with-values.png
KCM without values
  https://git.reviewboard.kde.org/media/uploaded/files/2014/05/07/89b1ef8e-803f-42fb-b2cb-52b776246598__kcm-without-values.png
In Systemsettings
  https://git.reviewboard.kde.org/media/uploaded/files/2014/05/08/65025e3c-30d1-4d91-8173-314fecb39241__kcm-in-systemsettings.png


Thanks,

Martin Gräßlin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140603/4276f1ba/attachment.html>