Review Request 118390: Powerdevil KCM Updates

[Andrew Lake]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118390/#review58996
-----------------------------------------------------------


The group box HIG has been updated after discussion on the HIG mailing list. Using a group box with the 'flat' property set true is now recommended; it provides a consistent way to use spacing to group visual elements without the line-y, boxy noise of a visible frame. If you used group boxes here and followed this new guidance you should get the visual design you're aiming for with more consistent spacing.

Hope this helps!

- Andrew Lake


On June 2, 2014, 4:04 p.m., Sebastian Kügler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118390/
> -----------------------------------------------------------
> 
> (Updated June 2, 2014, 4:04 p.m.)
> 
> 
> Review request for Plasma, Solid and KDE Usability.
> 
> 
> Repository: powerdevil
> 
> 
> Description
> -------
> 
> This is a series of UI updates I've applied to the powerdevil KCMs. You can find them as individual patch series in the sebas/kcmupdates branch.
> 
> General:
> - Less icon usage, especially in the form layouts
> - Title casing throughout
> - Better HIG compliance (not 100%, but improved)
> - Energy Saving / Actions UI now scales with dialog
> - Proper usage of FormLayouts
> - A bunch of cleanups of dead code
> - Parenting fixes
> 
> In Detail:
> 
> * Improve Advanced Settings page
> 
> - Use a QFormLayout, and do it properly
> - Fix up spacing and alignment
> - Remove icons before titles
> - Use Title Case for Labels
> - Shorter labels for better readability
> 
> * Clean up brightness-OSD-related dead code
> 
> 
> * Make powerdevil actions layout stretch out horizontally
> 
> 
> * Compile-time connections in actionconfigwidget
> 
> 
> * widget and layout parenting fixes
> 
> 
> * No bold font, increased spacing instead
> 
> This removes the bold fonts from the checkboxes, as that is non-standard
> in the HIG. In order to make it look a bit more structured between the
> sections, a bit of spacing is added.
> 
> * Remove icons from actions
> 
> The icons are really small and add more visual noise than being useful.
> 
> * Streamline Comments of KCMs
> 
> 
> * Clean up dead code
> 
> 
> Diffs
> -----
> 
>   daemon/actions/bundled/brightnesscontrolconfig.cpp fea2a3e 
>   daemon/actions/bundled/dimdisplayconfig.cpp f683935 
>   daemon/actions/bundled/keyboardbrightnesscontrol.cpp 44dbcd8 
>   daemon/actions/bundled/keyboardbrightnesscontrolconfig.cpp 3177267 
>   daemon/actions/bundled/powerdevilbrightnesscontrolaction.desktop 9f03d7f 
>   daemon/actions/bundled/powerdevildimdisplayaction.desktop df8d7e2 
>   daemon/actions/bundled/powerdevilhandlebuttoneventsaction.desktop 58dccc0 
>   daemon/actions/bundled/powerdevilkeyboardbrightnesscontrolaction.desktop 231c5d6 
>   daemon/actions/bundled/powerdevilrunscriptaction.desktop 465768c 
>   daemon/actions/bundled/powerdevilsuspendsessionaction.desktop 4bd8859 
>   daemon/actions/bundled/runscriptconfig.cpp c0d3adb 
>   daemon/actions/dpms/powerdevildpmsaction.desktop 0492036 
>   daemon/actions/dpms/powerdevildpmsactionconfig.cpp 4d96273 
>   daemon/actions/powerdevilaction.desktop 5b74fea 
>   daemon/backends/hal/powerdevilhalbackend.desktop 27afb55 
>   daemon/backends/upower/backlight_helper_actions.actions 6ffa496 
>   daemon/backends/upower/powerdevilupowerbackend.desktop a963844 
>   daemon/powerdevil.desktop 20d31c9 
>   kcmodule/activities/activitypage.cpp 48e9c6c 
>   kcmodule/activities/powerdevilactivitiesconfig.desktop 449ca0e 
>   kcmodule/common/actionconfigwidget.cpp 2161c84 
>   kcmodule/common/actioneditwidget.cpp 4c67b4f 
>   kcmodule/global/GeneralPage.cpp d025e42 
>   kcmodule/global/generalPage.ui 2ce7cef 
>   kcmodule/global/powerdevilglobalconfig.desktop 21d0212 
>   kcmodule/profiles/EditPage.cpp a674ccb 
>   kcmodule/profiles/powerdevilprofilesconfig.desktop 9243a8f 
>   kcmodule/profiles/profileEditPage.ui dc26579 
>   powerdevil.notifyrc 36acdb6 
> 
> Diff: https://git.reviewboard.kde.org/r/118390/diff/
> 
> 
> Testing
> -------
> 
> Tested in kcmshell5 and systemsettings, still fully functional.
> 
> 
> File Attachments
> ----------------
> 
> Energy Saving page before
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/05/28/680a38ab-18d6-4343-86e8-6d6aeaf63032__powerdevil-kcm-profiles-before.png
> Energy Saving page after
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/05/28/30357866-df50-4c1a-afc2-63e3e565f55a__powerdevil-kcm-profiles-after.png
> Advanced page after
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/05/28/36401d04-da7a-4d30-8b6d-a64ccf3a7865__powerdevil-kcm-advanced-after.png
> Advanced page before
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/05/28/e06c29ef-c926-4ae9-b01b-f502c3cfd0a0__powerdevil-kcm-advanced-before.png
> 
> 
> Thanks,
> 
> Sebastian Kügler
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140602/2586fbbf/attachment-0001.html>