Review Request 118470: Avoid references to QApplication

Aleix Pol Gonzalez aleixpol at kde.org
Mon Jun 2 15:40:54 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118470/#review58986
-----------------------------------------------------------

Ship it!


Ship It!

- Aleix Pol Gonzalez


On June 2, 2014, 3:38 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118470/
> -----------------------------------------------------------
> 
> (Updated June 2, 2014, 3:38 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> Avoid references to QApplication
> 
> They potentially cause problems when running in QGuiApplication
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/core/units.cpp 0f20b8e 
>   src/plasma/private/theme_p.cpp 56c7132 
> 
> Diff: https://git.reviewboard.kde.org/r/118470/diff/
> 
> 
> Testing
> -------
> 
> change qApp macro in QApplication to qobject_cast and then fixed wherever my application crashed.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140602/057786e8/attachment.html>


More information about the Plasma-devel mailing list