Review Request 118469: KRunner: Stop using the dialog class
Marco Martin
notmart at gmail.com
Mon Jun 2 14:17:31 UTC 2014
> On June 2, 2014, 2:13 p.m., David Edmundson wrote:
> > krunner/view.cpp, line 85
> > <https://git.reviewboard.kde.org/r/118469/diff/1/?file=277433#file277433line85>
> >
> > If you really can't fix dialog create a tiny QML file with the contents
> >
> > import org.kde.plasmacore 2.0
> > FrameSvgItem {
> > svg:...
> > anchors.fill: parent
> > }
> >
> >
> > then do a setSource(myQMLFile.qml)
> >
> > that way you won't need to clone half the world to load an.
That would be already better.
but would still not have shadows, shaped blur behind or window masks
- Marco
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118469/#review58973
-----------------------------------------------------------
On June 2, 2014, 1:15 p.m., Vishesh Handa wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118469/
> -----------------------------------------------------------
>
> (Updated June 2, 2014, 1:15 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> KRunner: Stop using the dialog class
>
> The dialog class provides a number of features such as resizing itself
> when the item size changes, vice versa, and has slightly complex logic
> to handle to being a tooltip / dialog / etc. We do not really need any
> of this logic. We're just a simple window with a item + border.
>
> This removes the duplicated dialog.h header file, but it unfortunately
> introduces a copy of framesvgitem.*, units.*, and svgtexturenode.h. This
> should be a temporary copy until these files are exported properly.
>
> This patch fixes all the annoying flickering issues with krunner and
> makes it much much smoother. It also fixes issues where the top border
> is initially present but later disappears.
>
>
> Diffs
> -----
>
> krunner/view.h fe7fa1c
> krunner/units.h PRE-CREATION
> krunner/units.cpp PRE-CREATION
> krunner/svgtexturenode.h PRE-CREATION
> krunner/framesvgitem.cpp PRE-CREATION
> krunner/view.cpp 8e1b448
> krunner/framesvgitem.h PRE-CREATION
> krunner/dialog.h 6759a6e
> krunner/CMakeLists.txt c7dbd71
>
> Diff: https://git.reviewboard.kde.org/r/118469/diff/
>
>
> Testing
> -------
>
> Is much much smoother, and the number of repaints/resizes are much less. Tested by comparing frames via apitrace.
>
>
> File Attachments
> ----------------
>
> KRunner + Dialog Class
> https://git.reviewboard.kde.org/media/uploaded/files/2014/06/02/3b64d656-f080-437b-be5e-8d8e0a3e10ee__krunner-dialog.png
> KRunner without dialog
> https://git.reviewboard.kde.org/media/uploaded/files/2014/06/02/84f19377-f984-4c17-887e-b661fb5ec9b1__krunner-nodialog.png
>
>
> Thanks,
>
> Vishesh Handa
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140602/02bfc967/attachment-0001.html>
More information about the Plasma-devel
mailing list