Review Request 118469: KRunner: Stop using the dialog class

[Vishesh Handa]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118469/
-----------------------------------------------------------

(Updated June 2, 2014, 1:15 p.m.)


Review request for Plasma.


Changes
-------

Added screenshots showing before and after


Repository: plasma-workspace


Description
-------

    KRunner: Stop using the dialog class

    The dialog class provides a number of features such as resizing itself
    when the item size changes, vice versa, and has slightly complex logic
    to handle to being a tooltip / dialog / etc. We do not really need any
    of this logic. We're just a simple window with a item + border.

    This removes the duplicated dialog.h header file, but it unfortunately
    introduces a copy of framesvgitem.*, units.*, and svgtexturenode.h. This
    should be a temporary copy until these files are exported properly.

    This patch fixes all the annoying flickering issues with krunner and
    makes it much much smoother. It also fixes issues where the top border
    is initially present but later disappears.


Diffs
-----

  krunner/view.h fe7fa1c 
  krunner/units.h PRE-CREATION 
  krunner/units.cpp PRE-CREATION 
  krunner/svgtexturenode.h PRE-CREATION 
  krunner/framesvgitem.cpp PRE-CREATION 
  krunner/view.cpp 8e1b448 
  krunner/framesvgitem.h PRE-CREATION 
  krunner/dialog.h 6759a6e 
  krunner/CMakeLists.txt c7dbd71 

Diff: https://git.reviewboard.kde.org/r/118469/diff/


Testing
-------

Is much much smoother, and the number of repaints/resizes are much less. Tested by comparing frames via apitrace.


File Attachments (updated)
----------------

KRunner + Dialog Class
  https://git.reviewboard.kde.org/media/uploaded/files/2014/06/02/3b64d656-f080-437b-be5e-8d8e0a3e10ee__krunner-dialog.png
KRunner without dialog
  https://git.reviewboard.kde.org/media/uploaded/files/2014/06/02/84f19377-f984-4c17-887e-b661fb5ec9b1__krunner-nodialog.png


Thanks,

Vishesh Handa

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140602/d5065f0e/attachment.html>