Review Request 118357: Disable the agenda part of the calendar

Martin Klapetek martin.klapetek at gmail.com
Mon Jun 2 12:44:47 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118357/
-----------------------------------------------------------

(Updated June 2, 2014, 12:44 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Repository: plasma-workspace


Description
-------

As agreed on irc (someday ago), the agenda part is useless until there's a proper agenda backend and should just be hidden. Here's a patch simply hiding the left part - it's easier to do just "visible: false" than comment it out and then comment out/remove all the lines referencing parts of the agenda, also cleaner.

I added a big comment at the file beginning, I'll fill the commit sha after committing so it can be easily reverted (the comment will be separate commit).

Screenshot attached.

Oh and you might want to remove the clock from panel and readd it/remove plasma config as the popup size seems to be saved and so after this patch you may still get the original-sized half-empty dialog.


Diffs
-----

  applets/digital-clock/package/contents/ui/CalendarView.qml 43812a4 

Diff: https://git.reviewboard.kde.org/r/118357/diff/


Testing
-------


File Attachments
----------------

Calendar without agenda
  https://git.reviewboard.kde.org/media/uploaded/files/2014/05/27/84880c21-1367-4d48-88db-7747553c40f5__plasma_cal1.png


Thanks,

Martin Klapetek

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140602/d763ae55/attachment.html>


More information about the Plasma-devel mailing list