Review Request 118038: Bring back a KCM for the screen locker
Sebastian Kügler
sebas at kde.org
Mon Jun 2 10:28:12 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118038/#review58942
-----------------------------------------------------------
Ship it!
Ship It!
- Sebastian Kügler
On May 8, 2014, 5:17 a.m., Martin Gräßlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118038/
> -----------------------------------------------------------
>
> (Updated May 8, 2014, 5:17 a.m.)
>
>
> Review request for Plasma and Thomas Pfeiffer.
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> Bring back a KCM for the screen locker
>
> Note: I will improve the default values to get them sane. That needs adjustements in the screenlocker source base and I want to get the review of the UI started earlier.
>
>
> Diffs
> -----
>
> ksmserver/screenlocker/kcm/screenlocker.desktop PRE-CREATION
> ksmserver/screenlocker/kcm/kcm.ui PRE-CREATION
> ksmserver/screenlocker/kcm/CMakeLists.txt PRE-CREATION
> ksmserver/screenlocker/kcm/kcm.cpp PRE-CREATION
> ksmserver/screenlocker/CMakeLists.txt 3407ea46d5046f2f5b2e7321d714ad1e65ffceea
>
> Diff: https://git.reviewboard.kde.org/r/118038/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> KCM with values
> https://git.reviewboard.kde.org/media/uploaded/files/2014/05/07/f70f34d6-2c5c-4638-8e43-d9d727fdb7cb__kcm-with-values.png
> KCM without values
> https://git.reviewboard.kde.org/media/uploaded/files/2014/05/07/89b1ef8e-803f-42fb-b2cb-52b776246598__kcm-without-values.png
> In Systemsettings
> https://git.reviewboard.kde.org/media/uploaded/files/2014/05/08/65025e3c-30d1-4d91-8173-314fecb39241__kcm-in-systemsettings.png
>
>
> Thanks,
>
> Martin Gräßlin
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140602/29860b1d/attachment.html>
More information about the Plasma-devel
mailing list