Review Request 118417: [klipper] Port from KDebug to QDebug

Sebastian Kügler sebas at kde.org
Mon Jun 2 09:52:19 UTC 2014



> On May 30, 2014, 3:39 p.m., Alexander Richardson wrote:
> > Shouldn't this rather use qCDebug() so that the output can be disabled?

I think it would be nice, but I'd also leave the choice between qDebug and qCDebug up to the maintainer -- Martin. :)

We haven't enforced it everywhere yet.


- Sebastian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118417/#review58827
-----------------------------------------------------------


On May 30, 2014, 10:29 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118417/
> -----------------------------------------------------------
> 
> (Updated May 30, 2014, 10:29 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> [klipper] Port from KDebug to QDebug
> 
> 
> Diffs
> -----
> 
>   klipper/actionstreewidget.cpp 201e32b821f526bc5869aaae6864a5723d2a2572 
>   klipper/configdialog.cpp 808be4e4ea0e42dbb3b9fb11abf4456e16caacdf 
>   klipper/editactiondialog.cpp 4719fc5eccf3c28b4d8824b54cbdf62d43805ebf 
>   klipper/history.cpp 486e8f77bb71d8e8b22b4dc330e96e080ab5f7c1 
>   klipper/historyimageitem.cpp 6fcb409400e62dd55caf551f229f28ebc68ff52a 
>   klipper/historyitem.cpp e9bdec76ef0e12fbfaead90487a7d772cc6fc5f4 
>   klipper/klipper.cpp 8847af324ff0c0c8e07d7e69ca473945cf001772 
>   klipper/klipperpopup.cpp 89d12adba2a3fcfa9cb2e65e52cb54c5f783eb07 
>   klipper/popupproxy.cpp 5d1b0a0d245c56c94a00cb9b191a727e008d4725 
>   klipper/urlgrabber.cpp 54085e8a28fb2836c80900759201f4e936da051b 
> 
> Diff: https://git.reviewboard.kde.org/r/118417/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140602/7cc5c613/attachment.html>


More information about the Plasma-devel mailing list