Review Request 119552: Kdeclarative: Introduce org.kde.kio component

[Antonis Tsiapaliokas]

> On July 31, 2014, 11:10 a.m., Aleix Pol Gonzalez wrote:
> > src/qmlcontrols/kioplugin/kio.cpp, line 33
> > <https://git.reviewboard.kde.org/r/119552/diff/1/?file=294573#file294573line33>
> >
> >     Why is it better than Qt.openUrl?
> >     
> >     And what does this have to do with KIO?
> 
> Marco Martin wrote:
>     Qt.openUrl can't execute desktop files (and apparently shouldn't for security reasons)
>     
>     this shouldn't be in a class called Kio at all, but KRun (that yes comes from kio)

Ok, everything should be renamed from "kio" to "krun", right?
Also the plugin name should be renamed from org.kde.kio to org.kde.krun?


- Antonis


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119552/#review63550
-----------------------------------------------------------


On July 31, 2014, 10:54 a.m., Antonis Tsiapaliokas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119552/
> -----------------------------------------------------------
> 
> (Updated July 31, 2014, 10:54 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kdeclarative
> 
> 
> Description
> -------
> 
> With the specific component we will be able to open files,documents,applications etc.
> Because until now we are not able to open them.
> 
> 
> Diffs
> -----
> 
>   src/qmlcontrols/CMakeLists.txt bab913b 
>   src/qmlcontrols/kioplugin/CMakeLists.txt PRE-CREATION 
>   src/qmlcontrols/kioplugin/kio.h PRE-CREATION 
>   src/qmlcontrols/kioplugin/kio.cpp PRE-CREATION 
>   src/qmlcontrols/kioplugin/kioplugin.h PRE-CREATION 
>   src/qmlcontrols/kioplugin/kioplugin.cpp PRE-CREATION 
>   src/qmlcontrols/kioplugin/qmldir PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/119552/diff/
> 
> 
> Testing
> -------
> 
> Everything seems to work ok.
> 
> * Applications open properly if we pass their desktop file as a parameter
> * Files and images are opening properly
> 
>  
> 
> 
> Thanks,
> 
> Antonis Tsiapaliokas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140731/b5f13694/attachment.html>